SaFi Bank Space : SaFi Definition Of Done - User Story

  • Produced code for presumed functionalities

  • Both normal/happy and exception/unhappy logic flows should be handled properly

  • Error messages should be readable and frontend-friendly, don’t return default error messages to the frontend and other API callers

  • Logging output and shipping to log aggressor

  • Don’t put sensitive customer information into logs (customer name, age, gender, passport/ID number, email address, phone number)

  • The code was scanned and passed the security checks

  • A peer code review performed

  • Lint check passing

  • Build without errors

  • Unit test cases covering normal and exception logic flows written and passing

  • Integration test cases coverage written and passing

  • ITEST cases written and passing

  • Any configurations(configuration/property file, environmental variables, etc) and build changes documented

  • Secrets are managed in the Secret management tool “Vault”

  • If It is applicable Data Base schema documented in Confluence and reverses back script available

  • If It is applicable API schema “Swagger” is documented in Confluence

  • If It is applicable Kafka stream schema is documented in Confluence

  • Static and dynamic scanning without security vulnerabilities

  • Data storage complies with the local Philippines regulations

  • We need a new dynamically created dev environment for the e2e test that we can change its environment variable separately. For example, shorten the grace period and last repayment period to make the auto test more easier.

  • Is Stress testing required?