Question | Questioner | Answer | Status |
|---|---|---|---|
Please introduce the total flow when BO request demand. After MVP, what is the whole process? |
| ||
Give some context upon an epic so that we can know the big picture and the connections among tasks for this epic (or Task and it’s sub tasks). |
| ||
About insertion and update of | There is no requirement about it before. |
| |
about SM-6963, about stop retrying, need to send ticket manager? | happy path, no need. |
| |
https://safibank.slack.com/archives/C03GPQ9KN02/p1668997477101189 | Matej answered it. |
| |
Atome was moved to "public launch" scope. Need handover all previously design, conversation and anything else related to it.  | answer:https://safibank.slack.com/archives/D03UZL7L7EG/p1669055325662239 |
| |
what the meaning of https://safibank.atlassian.net/wiki/spaces/ITArch/pages/200704278 | Pete wrote it, and will move the link under Credit Risk Management. |
| |
If there is more error code adding, what is the process? Need FE to modify corresponding？ FE display the description from BE? | The error message is used for logging purposes only (it is ignored in FE app) . The FE needs to convert the error code only to localized message. If the new error code is introduced:
|
| |
Save application , what is the logic about "Resetting the onboarding flow" 2. |
| ||
It seems that whenever we receive a API request, we are having multiple database transactions. What’s the reason behind? and aren’t we wanting to save the data all at once to improve the performance? | Idempotency Key Implementation: https://github.com/SafiBank/SaFiMono/pull/7115/files |
| |
When new APIs are to be implemented, how is coordination being done? Who decides what will be included in the contracts and different scenarios to be covered? | The contract is discussed beforehand and it should follow RESTful practices. Then BE introduces the contract and FE tries to use it. If it can’t be used it has to be updated based on the FE review. |
| |
Can we discuss about how customer can recover his account? For example he onboards in a phone, lost it and wants to access it again in a new phone? | As discussed during the handover, this is out of scope. Covered by IAM |
| |
Can we discuss about unfinished onboarding invalidation? How does it work? | see: https://safibank.atlassian.net/wiki/spaces/ITArch/pages/185008406/Onboarding+Customer+Scheduled+System+Processes#Invalidate-Unfinished-Onboardings |
| |
about ID card document verified, if the AAI detecting forgery is reliable. How to improve the whole process | The document verification feture (comes from backoffice squad) and ID Card forgery feature (comes from our requirements) are 2 separate things. If the backoffice squad would like to have a logic based on the ID Card forgery - we could implement it. |
| |
Hi, about vKYC, right now, because of kafka sending problem, after vKYC agent submiting, App will stuck in this step. Customer would click the button to initiate a call to agent again.
https://safibank.slack.com/archives/C03GPQ9KN02/p1669271539589489 | create Jira to solve it |
| |
search | AAI-GW: @Deprecated class OCRControllerV1 // can be removed after SM-7309 is DONE CM: @Deprecated fun createArea(...) // ask backoffice squad - but I think they are not using it - could be removed @Deprecated fun getRootLevelAreas(...) // FE should be ready, ask backoffice too @Deprecated fun getSubAreas(...) // FE should be ready, ask backoffice too @Deprecated fun createResidentialAddress(...) // FE should be ready - could be removed @Deprecated fun createResidentialAddress(...) // ask the backoffice if they are ready (if they migrated) @Deprecated fun getIdByPhoneNumber(...) // it should be ready to remove (maybe confirm with FE) @Deprecated fun getCustomerDocuments(...) // should not exist at all | ||
if agent didn’t pick all, how to do about vKYC | This is beyond the scope of our responsibility |
| |
What happen if VKYC picks up the call and the |  Workaround without VKYC API Update:
|
| |
every method use “ | add Jira task |
| |
face compare with ID card or previous selfie, didn’t check the document verified. I think it is risk. | the id card detecting forgery is done in OSP and vKYC. document verified is BO to take care |
| |
there is no process to describe what’s the interaction with other squad, like authenticate(iam), admin manager(backoffice) If the main process is belonging to another squad, it still need a confluence link to other squad’s process diagram. Then we can know which squad have relationship with customer squad. | |||
/v1/face-comparison/{livenessId} | FE doesn’t need to know it. It is the same with ID card forgery. |
| |
Offboarding process has 11 todo JIRAs, can give us as many context as possible. | Deven will push it in slack |
| |
Offboarding process: finish endpoint: in Confluence page, it says first lock customer locally, after some tasks done, unlock customer locally, I didn't see these steps in code | https://safibank.slack.com/archives/C03MD6K9EJV/p1669701187131399 |
| |
Sign up: otp smsErr property not used | https://safibank.slack.com/archives/C03MD6K9EJV/p1669701651963759 |
| |
Offboarding: listFailedOffboardingConditions() includes PENDING_OFFBOARDING OFFBOARDED |
| ||
Offboarding rollback | |||
Misc AAI VKYC reconciliation Sign up | 1, 2, 4: https://safibank.slack.com/archives/C03MD6K9EJV/p1669703441307939 https://github.com/SafiBank/SaFiMono/pull/8044 |
| |
Misc 3 GET /v1/vkyc-call/{transactiondId}/summary: confluence shows it's asyn, but code is sync call | 3: it is mentioned in 2 places and on the both places the call is sync see the following pictures:  source: https://safibank.atlassian.net/wiki/spaces/ITArch/pages/590076/Onboarding+Process#Video-KYC-call  |
| |
Misc 5 TODO - SM-4545 - This client call should be triggered asynchronously via Kafka for otp resend client. better some background | 5: REST call within DB transaction causes DB connection pool starvation → all the REST calls should be outside of DB transaction to improve higher availability + receiving the SMS is asyc process from customer’s perspective | ||
Where do we get the values for | From Pavel. exported from other system. Martin Vodila (Unlicensed) pass the script link here Script → app/scripts/tools/addresses_convertor/convert_raw_to_tree.dart (input is json exported from xls table) |
| |
Do we run Google Composer/Airflow scripts locally for testing purposes? |
| ||
who is the first person responsible for review code(customer, advanceai gateway) on github. | the whole team - it’s preferred to have at least 2 approvals |
| |
 about TODO, is it approved by Pavel and Risk team? Should we consider to implement it in next Sprint. there is similar case, please provide their context, and should we need continue to improve it.  | |||
about the deduplication rule, I want to improve it. What your suggestion?
| |||
It is strange one id card → two documents. I think from the model, one id card → one document(verification, deleted or not). the frontside, backside photo → two document(google storage) | |||
Is there any suggest to do idempotency? As I understanding, we should firstly list all controllers with idempotency header, and all consumers. Then collect all services and producer s that used by these controllers and consumers. finally add the idempotency-lib to these items. | |||
why does repository need transactional |
SM-7630
Attachments:
image-20221202-051950.png (image/png)
image-20221202-051243.png (image/png)
image-20221202-050918.png (image/png)
image-20221202-050851.png (image/png)
Screenshot_20221129_100418.png (image/png)
Screenshot_20221129_100327.png (image/png)
image-20221128-060926.png (image/png)
image-20221121-093203.png (image/png)