ID | BO14 |
EPIC | SM-1051 - BO: Maker - checker workflow Done |
US | SM-1133 - FE: Checker change rejection/approval Done |
STATUS | DONE |
Role: BOFE checker (based on the OKTA setup)
Objective: As a BOFE checker, I want to approve or reject changes
Reason: As checker, I need to see what change was proposed, by whom and why, so I can review and decide if they should be approved (updated) or rejected (discarded).
Functional requirements:
Pending approvals are part of the components Show pending changes for particular tab/section
Pending approvals list is in the Maker-Checker list page
Approve
Upon reviewing the proposed changes in modal view (and additional information, like Jira ticket), the Approve change button can be clicked and the approve flow triggered:
change will be marked as pending
approval logged in the audit log
change will be executed
change logged in the audit log
notification for Maker will be triggered, see: Maker notifications
confirmation dialog will be displayed
See Maker-checker flows for detailed flows and triggering notifications.
Reject
Proposed changes can be rejected by clicking the Reject change button and rejection flow triggered:
change marked as rejected
rejection logged in the audit log
notification for Maker will be triggered, see: Maker notifications
confirmation dialog will be displayed
Ascertain that approval / rejection actions can be done only once by introducing idempotency and correctly changing the request status.
Acceptance criteria: After clicking approve or reject in the modal view, acceptance / rejection flows will be triggered and in correct order, without errors.